Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TY: implement unsizing #8828

Merged
merged 2 commits into from
May 13, 2022
Merged

TY: implement unsizing #8828

merged 2 commits into from
May 13, 2022

Conversation

vlad20012
Copy link
Member

@vlad20012 vlad20012 commented May 11, 2022 •
edited
Loading

Fixes #5141, fixes #6484, fixes #4578

changelog: Implement unsize coercion in type inference. This fixes false-positive errors like type mismatch between Box<[u8]> and Box<[u8; 4]>

@vlad20012 vlad20012 self-assigned this May 11, 2022
@Undin
Copy link
Member

Undin commented May 12, 2022

@vlad20012 I think it should also fix #4578

@vlad20012 vlad20012 assigned mchernyavsky and unassigned vlad20012 May 13, 2022
@mchernyavsky mchernyavsky added this to In Progress in To test via automation May 13, 2022
@vlad20012 vlad20012 mentioned this pull request May 13, 2022
Merged
@vlad20012
Copy link
Member Author

bors r=mchernyavsky

@bors
Copy link
Contributor

bors bot commented May 13, 2022

Build succeeded:

@bors bors bot merged commit 2808aa4 into master May 13, 2022
To test automation moved this from In Progress to Test May 13, 2022
@bors bors bot deleted the ty-unsize branch May 13, 2022 17:26
@github-actions github-actions bot added this to the v171 milestone May 13, 2022
@mili-l mili-l self-assigned this May 17, 2022
@mili-l mili-l moved this from Test to Done in To test May 18, 2022
@vlad20012 vlad20012 mentioned this pull request Jun 23, 2022
Merged
bors bot added a commit that referenced this pull request Jul 6, 2022
@bors @vlad20012
Merge #8968
d9850da 
8968: PERF: optimize `coerceUnsized` for equivalent types r=vlad20012 a=vlad20012

Fixes a performance regression introduced in #8828

changelog: slightly speed up type inference

Co-authored-by: vlad20012 <beskvlad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@mchernyavsky mchernyavsky mchernyavsky approved these changes

Assignees

@mili-l mili-l

@mchernyavsky mchernyavsky

Labels
feature
Projects
To test
  
Done
Milestone
v171
5 participants
@vlad20012 @Undin @ozkriff @mchernyavsky @mili-l