Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANN: Provide lint-based suppress quick-fixes for some external linter annotations #8842

Merged
merged 2 commits into from Apr 15, 2023

Conversation

mchernyavsky
Copy link
Member

Closes #8794.

Screen Shot 2022-05-16 at 06 28 01

changelog: Provide lint-based suppress quick-fixes for external linter annotations

@mchernyavsky mchernyavsky added this to In Progress in To test via automation May 16, 2022
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Apr 14, 2023
8842: ANN: Provide lint-based suppress quick-fixes for external linter annotations r=vlad20012 a=mchernyavsky

Closes #8794.

<img width="683" alt="Screen Shot 2022-05-16 at 06 28 01" src="https://user-images.githubusercontent.com/6079006/168514928-834a459b-af5d-4cb5-a7b4-af06188f1eb6.png">

changelog: Provide lint-based suppress quick-fixes for external linter annotations


Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 14, 2023

Build failed:

@vlad20012
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Apr 14, 2023
8842: ANN: Provide lint-based suppress quick-fixes for external linter annotations r=vlad20012 a=mchernyavsky

Closes #8794.

<img width="683" alt="Screen Shot 2022-05-16 at 06 28 01" src="https://user-images.githubusercontent.com/6079006/168514928-834a459b-af5d-4cb5-a7b4-af06188f1eb6.png">

changelog: Provide lint-based suppress quick-fixes for external linter annotations


9287: RUN: Enable Debugger, Profiler, Valgrind, Code Coverage, and Build/Test tool windows for `bench` command r=vlad20012 a=mchernyavsky

Fixes #8878.

https://youtrack.jetbrains.com/issue/CPP-30242/Profiling-Support-for-Rust-cargo-bench-profile-dev

Note: default bench profile doesn't contain debug info. You have to use, for example, dev profile (add `--profile=dev` to your command).

changelog: Enable Debugger, Profiler, Valgrind, Code Coverage, and Build/Test tool windows for `bench` command


Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>
@bors
Copy link
Contributor

bors bot commented Apr 14, 2023

Build failed (retrying...):

bors bot added a commit that referenced this pull request Apr 14, 2023
8842: ANN: Provide lint-based suppress quick-fixes for external linter annotations r=vlad20012 a=mchernyavsky

Closes #8794.

<img width="683" alt="Screen Shot 2022-05-16 at 06 28 01" src="https://user-images.githubusercontent.com/6079006/168514928-834a459b-af5d-4cb5-a7b4-af06188f1eb6.png">

changelog: Provide lint-based suppress quick-fixes for external linter annotations


Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 14, 2023

Build failed:

@mchernyavsky
Copy link
Member Author

bors retry

@bors
Copy link
Contributor

bors bot commented Apr 15, 2023

Build succeeded:

@bors bors bot merged commit e03d7e7 into master Apr 15, 2023
42 checks passed
To test automation moved this from In Progress to Test Apr 15, 2023
@bors bors bot deleted the linter-suppress-quickfix branch April 15, 2023 13:57
@github-actions github-actions bot added this to the v193 milestone Apr 15, 2023
@mili-l mili-l self-assigned this Apr 17, 2023
@mchernyavsky mchernyavsky changed the title ANN: Provide lint-based suppress quick-fixes for external linter annotations ANN: Provide lint-based suppress quick-fixes for some external linter annotations Apr 21, 2023
@mili-l mili-l moved this from Test to Done in To test Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

Provide lint-based suppress quick-fixes for external linter annotations
4 participants