New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANN: Provide lint-based suppress quick-fixes for some external linter annotations #8842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchernyavsky
force-pushed
the
linter-suppress-quickfix
branch
from
May 16, 2022 06:49
25e7e8c
to
1b39705
Compare
Undin
reviewed
May 23, 2022
src/test/kotlin/org/rust/ide/annotator/fixes/ApplySuggestionFixTest.kt
Outdated
Show resolved
Hide resolved
mchernyavsky
force-pushed
the
linter-suppress-quickfix
branch
from
May 29, 2022 16:16
1b39705
to
0b7f35b
Compare
mchernyavsky
force-pushed
the
linter-suppress-quickfix
branch
from
March 27, 2023 11:25
0b7f35b
to
5b5101e
Compare
mchernyavsky
force-pushed
the
linter-suppress-quickfix
branch
from
April 13, 2023 13:01
5b5101e
to
c3bc492
Compare
vlad20012
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
bors bot
added a commit
that referenced
this pull request
Apr 14, 2023
8842: ANN: Provide lint-based suppress quick-fixes for external linter annotations r=vlad20012 a=mchernyavsky Closes #8794. <img width="683" alt="Screen Shot 2022-05-16 at 06 28 01" src="https://user-images.githubusercontent.com/6079006/168514928-834a459b-af5d-4cb5-a7b4-af06188f1eb6.png"> changelog: Provide lint-based suppress quick-fixes for external linter annotations Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
Build failed: |
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 14, 2023
8842: ANN: Provide lint-based suppress quick-fixes for external linter annotations r=vlad20012 a=mchernyavsky Closes #8794. <img width="683" alt="Screen Shot 2022-05-16 at 06 28 01" src="https://user-images.githubusercontent.com/6079006/168514928-834a459b-af5d-4cb5-a7b4-af06188f1eb6.png"> changelog: Provide lint-based suppress quick-fixes for external linter annotations 9287: RUN: Enable Debugger, Profiler, Valgrind, Code Coverage, and Build/Test tool windows for `bench` command r=vlad20012 a=mchernyavsky Fixes #8878. https://youtrack.jetbrains.com/issue/CPP-30242/Profiling-Support-for-Rust-cargo-bench-profile-dev Note: default bench profile doesn't contain debug info. You have to use, for example, dev profile (add `--profile=dev` to your command). changelog: Enable Debugger, Profiler, Valgrind, Code Coverage, and Build/Test tool windows for `bench` command Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com> Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Apr 14, 2023
8842: ANN: Provide lint-based suppress quick-fixes for external linter annotations r=vlad20012 a=mchernyavsky Closes #8794. <img width="683" alt="Screen Shot 2022-05-16 at 06 28 01" src="https://user-images.githubusercontent.com/6079006/168514928-834a459b-af5d-4cb5-a7b4-af06188f1eb6.png"> changelog: Provide lint-based suppress quick-fixes for external linter annotations Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
Build failed: |
bors retry |
Build succeeded: |
mchernyavsky
changed the title
ANN: Provide lint-based suppress quick-fixes for external linter annotations
ANN: Provide lint-based suppress quick-fixes for some external linter annotations
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8794.
changelog: Provide lint-based suppress quick-fixes for external linter annotations