Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARGO: support IDEs without Build Tools settings #9097

Merged
merged 1 commit into from Aug 1, 2022

Conversation

Undin
Copy link
Member

@Undin Undin commented Jul 20, 2022

Rider doesn't provide Build | Build Tools settings. As a result, Cargo settings cannot be added as a child of Build Tools and the platform adds it to as a root setting panel

The main idea is to keep Cargo settings under Languages & Frameworks | Rust if Build | Build Tools doesn't exist, and add Build Tools panel to Cargo settings.

Screen Shot 2022-07-21 at 00 22 33

To achieve it, CargoBuildToolConfigurableProvider and CargoProjectConfigurableProvider were introduced since they provide more flexible way to manage when CargoConfigurable should be shown and how

Fixes #9077

changelog: Properly add Cargo settings in Rider 2022.2

Rider doesn't provide `Build | Build Tools` settings. As a result, `Cargo` settings cannot be added as a child of `Build Tools` and the platform adds it to as a root setting panel

The main idea is to keep `Cargo` settings under `Languages & Frameworks | Rust` if `Build | Build Tools` doesn't exist, and add `Build Tools` panel to `Cargo` settings.
To achieve it, `CargoBuildToolConfigurableProvider` and `CargoProjectConfigurableProvider` were introduced since they provide more flexible way to manage when `CargoConfigurable` should be shown and how
@Undin Undin added the fix Pull requests that fix some bug(s) label Jul 20, 2022
@Undin Undin added this to In Progress in To test via automation Jul 20, 2022
@Undin Undin requested a review from mchernyavsky July 27, 2022 20:25
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 1, 2022

Build succeeded:

@bors bors bot merged commit ae11aa6 into master Aug 1, 2022
To test automation moved this from In Progress to Test Aug 1, 2022
@bors bors bot deleted the undin/9077-rider-cargo-settings branch August 1, 2022 05:41
@github-actions github-actions bot added this to the v177 milestone Aug 1, 2022
@mili-l mili-l self-assigned this Aug 1, 2022
@Undin Undin modified the milestones: v177, v176 Aug 1, 2022
@mili-l mili-l moved this from Test to Done in To test Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

Cargo settings was moved to wrong place in Rider
4 participants