Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES: Fix propagation of include!-ed macros to child modules #9107

Merged
merged 1 commit into from Jul 23, 2022
Merged

RES: Fix propagation of include!-ed macros to child modules #9107

merged 1 commit into from Jul 23, 2022

Conversation

dima74
Copy link
Member

@dima74 dima74 commented Jul 23, 2022 •
edited

Fixes #8559

changelog: Fix resolve of macros declared in include!-ed files in some cases

@dima74 dima74 added the fix Pull requests that fix some bug(s) label Jul 23, 2022
@dima74 dima74 added this to In Progress in To test via automation Jul 23, 2022
vlad20012
vlad20012 approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jul 23, 2022
@bors @dima74
Merge #9107
670c06d 
9107: RES: Fix propagation of `include!`-ed macros to child modules r=vlad20012 a=dima74

Fixes #8559

changelog: Fix resolve of macros declared in `include!`-ed files in some cases


Co-authored-by: Dmitry Murzin <diralik@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Jul 23, 2022

Build failed:

@vlad20012
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Jul 23, 2022
@bors @dima74
Merge #9107
b67c24c 
9107: RES: Fix propagation of `include!`-ed macros to child modules r=vlad20012 a=dima74

Fixes #8559

changelog: Fix resolve of macros declared in `include!`-ed files in some cases


Co-authored-by: Dmitry Murzin <diralik@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Jul 23, 2022

Build failed:

@dima74
Copy link
Member Author

dima74 commented Jul 23, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Jul 23, 2022

Build succeeded:

@bors bors bot merged commit 5aa5c86 into master Jul 23, 2022
To test automation moved this from In Progress to Test Jul 23, 2022
@bors bors bot deleted the diralik/fix-propagate-macro-def-from-include-file branch July 23, 2022 17:03
@github-actions github-actions bot added this to the v176 milestone Jul 23, 2022
@mili-l mili-l moved this from Test to Done in To test Jul 27, 2022
@mili-l mili-l self-assigned this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 vlad20012 approved these changes

Assignees

@mili-l mili-l

@vlad20012 vlad20012

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v176
Development

Successfully merging this pull request may close these issues.

included macros are not proceed correctly in mod
3 participants
@dima74 @vlad20012 @mili-l