FIX: Do not allow empty member selection in Extract struct fields and Generate getter/setter dialog #9146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two small fixes to the
Extract struct fieldsrefactoring dialog, and one larger fix amongst all member-based refactorings. These refactorings enabled the "allow empty selection" option of the member selection dialog, which made it possible to runExtract Fields,Generate getter,Generate setterandGenerate constructorrefactorings with no members selected. This doesn't really make sense though, the only refactoring where it might be remotely useful isGenerate constructor.I have thus disabled empty selection for the mentioned refactorings, with the exception of
Generate constructor.Fixes: #9130
changelog: Do not enable struct field extraction or getter/setter generation of no fields are selected.