Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RES: Fix cache invalidation after change "Expand macros" settings #9151

Merged
merged 1 commit into from Aug 7, 2022

Conversation

dima74
Copy link
Member

@dima74 dima74 commented Aug 2, 2022

Currently when change "Expand macros" option, we have two problems:

  • CrateDefMaps don't rebuild
  • structureModificationTracker doesn't increment if option was disabled but becomes enabled

This may lead to problems like (thanks @neonaot):

macro_rules! gen {
    () => { fn func() {} }
}
gen!();
fn main() {
    func();
}
  • Disable "Expand macros" - func is unresolved (good)
  • Enable "Expand macros" - func is still unresolved (bad)

changelog: Fix cache invalidation after change "Expand macros" settings

@dima74 dima74 added the fix Pull requests that fix some bug(s) label Aug 2, 2022
@dima74 dima74 added this to In Progress in To test via automation Aug 2, 2022
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 7, 2022

Build succeeded:

@bors bors bot merged commit 5372a3f into master Aug 7, 2022
To test automation moved this from In Progress to Test Aug 7, 2022
@bors bors bot deleted the diralik/fix-toggle-macro-expansion branch August 7, 2022 16:03
@github-actions github-actions bot added this to the v176 milestone Aug 7, 2022
@neonaot neonaot self-assigned this Aug 8, 2022
@neonaot neonaot moved this from Test to Done in To test Aug 8, 2022
@dima74 dima74 changed the title RES: Fix cache invalidation after toggle "Expand macros" settings RES: Fix cache invalidation after change "Expand macros" settings Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants