Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slice pretty-printers #9168

Merged
merged 1 commit into from Aug 9, 2022
Merged

Add slice pretty-printers #9168

merged 1 commit into from Aug 9, 2022

Conversation

artemmukhin
Copy link
Member

Add GDB/LLDB pretty-printers to show the contents and the size of Rust slices.

Fixes #8519.

Screenshot 2022-08-08 at 13 26 35

changelog: Add debugger pretty-printers to show the contents and the size of Rust slices

@artemmukhin artemmukhin requested a review from Undin August 8, 2022 12:35
@artemmukhin artemmukhin added this to In Progress in To test via automation Aug 8, 2022
Undin
Undin reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests fail

prettyPrinters/lldb_providers.py Outdated Show resolved Hide resolved
@artemmukhin artemmukhin force-pushed the ortem/slice-pretty-printers branch 2 times, most recently from cdfa112 to 2cfabd6 Compare August 9, 2022 14:10
@artemmukhin
Copy link
Member Author

Some tests fail

@Undin That was an interesting situation to investigate #9178

Undin
Undin approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 9, 2022

Build succeeded:

@bors bors bot merged commit e27baa8 into master Aug 9, 2022
To test automation moved this from In Progress to Test Aug 9, 2022
@bors bors bot deleted the ortem/slice-pretty-printers branch August 9, 2022 23:36
@github-actions github-actions bot added this to the v177 milestone Aug 9, 2022
@neonaot neonaot self-assigned this Aug 15, 2022
@neonaot neonaot moved this from Test to Done in To test Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Undin Undin Undin approved these changes

Assignees

@Undin Undin

@neonaot neonaot

Labels
feature
Projects
To test
  
Done
Milestone
v177
Development

Successfully merging this pull request may close these issues.

Slice content is not shown while debugging
3 participants
@artemmukhin @Undin @neonaot