Hotfix #9110 by reverting #9021 #9169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
changed the title
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 8, 2022
9169: Hotfix #9110 by reverting #9021 r=vlad20012 a=vlad20012 Fixes #9110 #9021 leads to a stack overflow through `RsExpandedElement.getContextImpl` and `RsModulesIndex.getDeclarationsFor`. I think the proper fix is stopping using `RsModulesIndex` in `RsFile.doGetCachedData`, I'll do it later changelog: Fix possible Stack overflow introduced in the previous release of the plugin Co-authored-by: vlad20012 <beskvlad@gmail.com>
|
Timed out. |
|
bors r+ |
|
Build succeeded: |
|
@vlad20012 don't forget to cherry-pick this change into release branch |
bors bot
added a commit
that referenced
this pull request
Aug 24, 2022
9236: PERF: re-revert #9021 speed up `getIncludingMod` usages r=vlad20012 a=vlad20012 #9021 has been reverted in #9169 because of #9110. Now it can be enabled again because we got rid of recursion in `RsFile.getCachedData()` in #9171 changelog: Enable again [the optimization](#9021) reverted in the previous release. Slightly speed up name resolution Co-authored-by: vlad20012 <beskvlad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9110
#9021 leads to a stack overflow through
RsExpandedElement.getContextImplandRsModulesIndex.getDeclarationsFor.I think the proper fix is stopping using
RsModulesIndexinRsFile.doGetCachedData, I'll do it laterchangelog: Fix possible Stack overflow introduced in the previous release of the plugin