New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TY&RES: ignore impl
s from non-dependency crates
#9229
Conversation
src/main/kotlin/org/rust/lang/core/resolve/RsImplIndexAndTypeAliasCache.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/lang/core/resolve/RsImplIndexAndTypeAliasCache.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/lang/core/resolve/RsImplIndexAndTypeAliasCache.kt
Show resolved
Hide resolved
Btw there are some regressions |
I just checked the //- tests/foo.rs
pub struct Foo;
impl Foo {
pub fn foo(&self) {}
}
//- tests/a.rs
mod foo;
fn main() {
foo::Foo.foo();
} //^ tests/foo.rs
//- tests/b.rs
mod foo;
fn main() {
foo::Foo.foo();
} UPD: I've added a test with this case #9283 |
859773e
to
f055165
Compare
I think it is ok because currently we don't fully support files included in module tree multiple times in resolve, etc. What about |
It seems like there are a lot of fixed unresolved references false-positives that lead to the fact that more types has been inferred that in turn lead some new false-positives with these types. So this seems pretty fine
I'm going to fix it soon anyway |
Now `TyFingerprint`-based cache is global, but `Ty`-based caches are local. The new design helps with `impl`s filtering based on a crate where located a function in which we infer types
f055165
to
f83d6b3
Compare
bors r=dima74 |
Build succeeded: |
No description provided.