PERF: move recursion guard out of advancedResolve
#9337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and use it only for default type parameter values.
The only purpose of that recursion guard is to prevent infinite recursion in such cases:
```
pub trait Foo<A=Foo> {
type Output = Self;
}
type T = Foo;
```
(see `test no stack overflow when trait type parameter default value refers to the trait name`)
|
Build succeeded: |
bors
bot
deleted the
perf-move-recursion-guard-advanced-resolve-to-default-values-only
branch
bors bot
added a commit
that referenced
this pull request
Oct 18, 2022
9567: Fix #9565 stack overflow when dyn trait used as Self ty in where clause r=vlad20012 a=vlad20012 Fixes #9565 The type inference bug existed since a while, but it escalated to a stack overflow after one of these PRs: #9211, #9337, #9338 changelog: Fix possible stack overflow during type inference Co-authored-by: vlad20012 <beskvlad@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 18, 2022
9567: Fix #9565 stack overflow when dyn trait used as Self ty in where clause r=vlad20012 a=vlad20012 Fixes #9565 The type inference bug existed since a while, but it escalated to a stack overflow after one of these PRs: #9211, #9337, #9338 changelog: Fix possible stack overflow during type inference Co-authored-by: vlad20012 <beskvlad@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 18, 2022
9567: Fix #9565 stack overflow when dyn trait used as Self ty in where clause r=vlad20012 a=vlad20012 Fixes #9565 The type inference bug existed since a while, but it escalated to a stack overflow after one of these PRs: #9211, #9337, #9338 changelog: Fix possible stack overflow during type inference Co-authored-by: vlad20012 <beskvlad@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 18, 2022
9567: Fix #9565 stack overflow when dyn trait used as Self ty in where clause r=dima74 a=vlad20012 Fixes #9565 The type inference bug existed since a while, but it escalated to a stack overflow after one of these PRs: #9211, #9337, #9338 changelog: Fix possible stack overflow during type inference Co-authored-by: vlad20012 <beskvlad@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 19, 2022
9567: Fix #9565 stack overflow when dyn trait used as Self ty in where clause r=vlad20012 a=vlad20012 Fixes #9565 The type inference bug existed since a while, but it escalated to a stack overflow after one of these PRs: #9211, #9337, #9338 changelog: Fix possible stack overflow during type inference Co-authored-by: vlad20012 <beskvlad@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 19, 2022
9567: Fix #9565 stack overflow when dyn trait used as Self ty in where clause r=vlad20012 a=vlad20012 Fixes #9565 The type inference bug existed since a while, but it escalated to a stack overflow after one of these PRs: #9211, #9337, #9338 changelog: Fix possible stack overflow during type inference Co-authored-by: vlad20012 <beskvlad@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 19, 2022
9524: GRD: update IDE and plugin dependencies for 223 builds r=Undin a=Undin Also, temporarily use snapshot version of gradle-intellij-plugin because it contains fixes to properly launch the atest 2022.3 IDEs 9567: Fix #9565 stack overflow when dyn trait used as Self ty in where clause r=vlad20012 a=vlad20012 Fixes #9565 The type inference bug existed since a while, but it escalated to a stack overflow after one of these PRs: #9211, #9337, #9338 changelog: Fix possible stack overflow during type inference Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru> Co-authored-by: vlad20012 <beskvlad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and use it only for default type parameter values.
The only purpose of that recursion guard is to prevent infinite recursion in such cases:
(see
test no stack overflow when trait type parameter default value refers to the trait name)The PR is a further optimization of "resolve nested paths at once", see #9211.
changelog: Slightly speed up name resolution