Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INSP: Add unused_labels warning and fix #9375

Merged
merged 1 commit into from Mar 29, 2023
Merged

INSP: Add unused_labels warning and fix #9375

merged 1 commit into from Mar 29, 2023

Conversation

ozkriff
Copy link
Member

@ozkriff ozkriff commented Sep 19, 2022 •
edited

image

Depends on #9374 ("RES: Fix nested labels shadowing")
Part of #5888 ("Compiler lints support")

changelog: Add labels inspection and quick-fixes for it

@ozkriff ozkriff marked this pull request as ready for review October 7, 2022 08:05
@ozkriff ozkriff added the feature label Oct 7, 2022
@intellij-rust-bot intellij-rust-bot added this to In Progress in To test Oct 7, 2022
@artemmukhin artemmukhin self-assigned this Nov 30, 2022
artemmukhin
artemmukhin requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@artemmukhin artemmukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for minor comments

src/main/kotlin/org/rust/ide/inspections/lints/RsUnusedLabelsInspection.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/ide/inspections/lints/RsUnusedLabelsInspection.kt Outdated Show resolved Hide resolved
src/test/kotlin/org/rust/ide/inspections/lints/RsUnusedLabelsInspectionTest.kt Outdated Show resolved Hide resolved
@ozkriff ozkriff assigned vlad20012 and unassigned artemmukhin Mar 29, 2023
vlad20012
vlad20012 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 29, 2023

Build succeeded:

@bors bors bot merged commit 99036f8 into intellij-rust:master Mar 29, 2023
42 checks passed
To test automation moved this from In Progress to Test Mar 29, 2023
@github-actions github-actions bot added this to the v192 milestone Mar 29, 2023
@ozkriff ozkriff deleted the ozkriff/lint-unused-labels branch March 30, 2023 04:03
@neonaot neonaot self-assigned this Mar 31, 2023
@neonaot
Copy link
Member

neonaot commented Mar 31, 2023

Hi!
Not related to this PR functionality, but for the protocol: I've found a problem with labels completion: #10314

@neonaot neonaot moved this from Test to Done in To test Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 vlad20012 approved these changes

@artemmukhin artemmukhin Awaiting requested review from artemmukhin

Assignees

@vlad20012 vlad20012

@neonaot neonaot

Labels
feature
Projects
To test
  
Done
Milestone
v192
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ozkriff @neonaot @vlad20012 @artemmukhin