Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #9432 random false-positives caused by GC activity #9461

Merged
merged 1 commit into from Oct 5, 2022

Conversation

vlad20012
Copy link
Member

@vlad20012 vlad20012 commented Oct 4, 2022

Fixes #9432. See technical explanation here.
Actually, the bug is a wrong (missing) implementation of CargoBasedCrate.equals/hashCode.

Actually, the bug is a wrong (missing) implementation of CargoBasedCrate.equals/hashCode
@vlad20012 vlad20012 added the fix Pull requests that fix some bug(s) label Oct 4, 2022
@vlad20012 vlad20012 added this to the v180 milestone Oct 4, 2022
@vlad20012 vlad20012 added this to In Progress in To test via automation Oct 4, 2022
Copy link
Member

@dima74 dima74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 5, 2022

Build succeeded:

@bors bors bot merged commit 8826911 into master Oct 5, 2022
To test automation moved this from In Progress to Test Oct 5, 2022
@bors bors bot deleted the fix-issue-9432-GC-crate-graph branch October 5, 2022 11:41
@Undin
Copy link
Member

Undin commented Oct 5, 2022

@vlad20012 I've cherry-picked this change int master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

false positives when detecting errors in editor
3 participants