Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type info action inside attribute procedural macro calls #9832

Merged
merged 1 commit into from Dec 1, 2022
Merged

Fix type info action inside attribute procedural macro calls #9832

merged 1 commit into from Dec 1, 2022

Conversation

vlad20012
Copy link
Member

@vlad20012 vlad20012 commented Dec 1, 2022 •
edited

Previously that action has never worked in attr proc macros before. A user always saw the message "Select an expression!":
image
Now it should work fine.

changelog: Fix type info action (Ctrl+Shift+P) inside attribute procedural macro calls

@vlad20012 vlad20012 added the fix Pull requests that fix some bug(s) label Dec 1, 2022
@vlad20012 vlad20012 self-assigned this Dec 1, 2022
@intellij-rust-bot intellij-rust-bot added this to In Progress in To test Dec 1, 2022
@vlad20012
Copy link
Member Author

bors r+

@vlad20012 vlad20012 mentioned this pull request Dec 1, 2022
Draft
@bors
Copy link
Contributor

bors bot commented Dec 1, 2022

Build succeeded:

@bors bors bot merged commit 460e93b into master Dec 1, 2022
To test automation moved this from In Progress to Test Dec 1, 2022
@bors bors bot deleted the fix-type-info-in-in-attr-macro-calls branch December 1, 2022 18:28
@github-actions github-actions bot added this to the v185 milestone Dec 1, 2022
@neonaot neonaot self-assigned this Dec 6, 2022
@neonaot neonaot moved this from Test to Done in To test Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vlad20012 vlad20012

@neonaot neonaot

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v185
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vlad20012 @neonaot