Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Add kill / retry action buttons to report table #123

Closed
sp35 opened this issue Jul 25, 2021 · 3 comments · Fixed by #125
Closed

Add kill / retry action buttons to report table #123

sp35 opened this issue Jul 25, 2021 · 3 comments · Fixed by #125
Labels
GSoC-2021 Issues to be worked on during GSoC-2021

Comments

@sp35
Copy link
Member

sp35 commented Jul 25, 2021

Actions buttons for kill and retry (for both an analyzer and connector).

Part of intelowlproject/IntelOwl#534

Context #101

@sp35 sp35 added the GSoC-2021 Issues to be worked on during GSoC-2021 label Jul 25, 2021
@sp35
Copy link
Member Author

sp35 commented Aug 1, 2021

image
Kill - image
Retry - image

I have two options in mind:

  • Two buttons on each row

    • Adds a new column Actions.
    • The buttons will be disabled if invalid for action, so no validation needs to be shown.
    • Con: large no of records, but it should also be considered that only running/pending plugins can be killed, similarly for retry.
  • Two buttons on top of the table

    • This is a standard option used for large records.
    • This would require changes in the endpoints to accept multiple plugins and handling which sub-requests failed in a single request made.
    • Checkbox for each row, selected ones can be chosen for action.
    • Validation can be shown using a hover message (on the action button) if invalid records have been chosen.

I think the first one is still a reasonable choice as these actions by nature aren't bulk specific, but I'm open to suggestions.

@mlodic
Copy link
Member

mlodic commented Aug 1, 2021

good argumentation. I agree with your analysis. For this case, maybe it is simpler to choose the first option

@sp35 sp35 linked a pull request Aug 3, 2021 that will close this issue
5 tasks
@sp35 sp35 added this to To do in Connectors Manager/ connectors via automation Aug 3, 2021
@sp35 sp35 moved this from To do to In progress in Connectors Manager/ connectors Aug 3, 2021
eshaan7 pushed a commit that referenced this issue Aug 6, 2021
* Add plugin retry and kill actions to ui
* add action validations, update styles, refactor
* fix polling issues, use flex fields for custom fetch
* change alert comment
@sp35
Copy link
Member Author

sp35 commented Aug 6, 2021

This can be closed now.

@sp35 sp35 closed this as completed Aug 6, 2021
Connectors Manager/ connectors automation moved this from In progress to Done Aug 6, 2021
@eshaan7 eshaan7 changed the title Add action buttons to report table Add kill / retry action buttons to report table Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
GSoC-2021 Issues to be worked on during GSoC-2021
Development

Successfully merging a pull request may close this issue.

2 participants