Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start with --traefik option #2305

Closed
agnorance opened this issue May 11, 2024 · 11 comments
Closed

Start with --traefik option #2305

agnorance opened this issue May 11, 2024 · 11 comments
Labels
bug Something isn't working

Comments

@agnorance
Copy link

What happened

I wanted to start your awesome project with traefik as the respective proxy, but got an error message indicating the --traefik option isn't known.

Environment

  1. OS: Ubuntu
  2. IntelOwl version: Latest

What did you expect to happen

I expect to have an additional container with traefik.

How to reproduce your issue

Clone project. Let ./initialize.sh run. Run:

# From your --help
start <env> <command> [OPTIONS]

ubuntu@intelowl:~/IntelOwl$ ./start prod up --traefik

Error messages and logs

Error! Invalid option --traefik.

@agnorance agnorance added the bug Something isn't working label May 11, 2024
@agnorance
Copy link
Author

Moved to discussions.

@agnorance agnorance closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2024
@fgibertoni
Copy link
Contributor

Hello @agnorance, thank you for reaching out! :)
I should have fixed the issue in #2307.
Can you try it to see if it works for you ?

@agnorance agnorance reopened this May 13, 2024
@agnorance
Copy link
Author

Hello @fgibertoni

Thanks for you quick response.

Do I have to run it from a different branch or is it already merged?

@agnorance
Copy link
Author

I also have a different problem:

ubuntu@intelowl:~/IntelOwl$ ./start prod up --traefik
WARN[0000] /home/ubuntu/IntelOwl/docker/default.yml: `version` is obsolete 
WARN[0000] /home/ubuntu/IntelOwl/docker/postgres.override.yml: `version` is obsolete 
WARN[0000] /home/ubuntu/IntelOwl/docker/redis.override.yml: `version` is obsolete 
WARN[0000] /home/ubuntu/IntelOwl/docker/traefik.override.yml: `version` is obsolete 
WARN[0000] The "c" variable is not set. Defaulting to a blank string. 
WARN[0000] The "c" variable is not set. Defaulting to a blank string. 
WARN[0000] The "c" variable is not set. Defaulting to a blank string. 
WARN[0000] The "c" variable is not set. Defaulting to a blank string. 
unable to get image 'intelowlproject/intelowl_nginx:"v6.0.2"': Error response from daemon: invalid reference format

Do you know this problem?

Kind regards,
agnorance

@mlodic
Copy link
Member

mlodic commented May 13, 2024

I have just pushed a new version. Please pull from the master branch and try again

@agnorance
Copy link
Author

Hello @mlodic

I still get the same error:

ubuntu@intelowl:~/IntelOwl$ ./start prod up --traefik

WARN[0000] /home/ubuntu/IntelOwl/docker/default.yml: `version` is obsolete 
WARN[0000] /home/ubuntu/IntelOwl/docker/postgres.override.yml: `version` is obsolete 
WARN[0000] /home/ubuntu/IntelOwl/docker/redis.override.yml: `version` is obsolete 
WARN[0000] /home/ubuntu/IntelOwl/docker/traefik.override.yml: `version` is obsolete 
unable to get image 'intelowlproject/intelowl_nginx:"v6.0.2"': Error response from daemon: invalid reference format

I have deleted the old clone and cloned the repo again, configured it according to the documentation.

It seems as if the ${REACT_APP_INTELOWL_VERSION} variable gets populated incorrectly with "":

# this:
intelowlproject/intelowl_nginx:"v6.0.2"'

# ...should probably be:
intelowlproject/intelowl_nginx:v6.0.2

# ...or even:
intelowlproject/intelowl_nginx:6.0.2

Kind regards

@mlodic
Copy link
Member

mlodic commented May 13, 2024

Honestly, this integration with Traefix is quite old and could require a review. I tried too and I noticed that the docker-compose file could be broken and it does not work as intended.
If you have some time, you could help us to fix it.

@agnorance
Copy link
Author

I might have a look into it if my boss gives me some time... ;-)

But as mentioned before, it seems as the value in your default .env file is wrong with the most current docker version:

### DO NOT CHANGE THIS VALUE !!
### It should be updated only when you pull latest changes off from the 'master' branch of IntelOwl.
# this variable must start with "REACT_APP_" to be used in the frontend too
REACT_APP_INTELOWL_VERSION="v6.0.2"
# if you want to use a nfs volume for shared files
# NFS_ADDRESS=

# Should be:

### DO NOT CHANGE THIS VALUE !!
### It should be updated only when you pull latest changes off from the 'master' branch of IntelOwl.
# this variable must start with "REACT_APP_" to be used in the frontend too
REACT_APP_INTELOWL_VERSION=v6.0.2
# if you want to use a nfs volume for shared files
# NFS_ADDRESS=

It seems to work now.

Kind regards

@mlodic
Copy link
Member

mlodic commented May 13, 2024

That's strange cause I can't replicate that issue. Anyway I am happy you managed to run the application

@agnorance
Copy link
Author

Hey @mlodic

I was able to get it running using the newest version of traefik 3.0.

Now, there was a bit of a hassle with getting everything on the same network and I also had to change some configuration regarding the ports used (nginx container).

Before I put the effort in and create a merge request and stuff: Would you even be interested in such an addition?

I think it would be really cool addition, as traefik allows for very easy setup and for example ip-based access control like this:

- "traefik.http.routers.nginx.middlewares=nginx-ipallowlist"
- "traefik.http.middlewares.nginx-ipallowlist.ipallowlist.sourcerange=<IP>" 

Kind regards

@agnorance agnorance reopened this May 17, 2024
@mlodic
Copy link
Member

mlodic commented May 17, 2024

sure! that would be really cool! feel free to open a PR, we'll review it and help!

mlodic pushed a commit that referenced this issue Jun 5, 2024
* add traefik config and options for dev and prod

working config with traefik

finish traefik config prod/dev

add documentation

* Update traefik_local.override.yml - remove comment

* rework prod/local traefik and add deletion of get-docker.sh

* split traefik compose into base, prod and local

* remove print of compose files

* parent c45c84a
author David Mihajlovic <david.mihajlovic@protonmail.com> 1716908101 +0200
committer David Mihajlovic <david.mihajlovic@protonmail.com> 1717135119 +0200

add traefik config and options for dev and prod

working config with traefik

finish traefik config prod/dev

add documentation

Vulners#1257 (#2340)

* vulners

* vulners wrapper

* docs

* lesser variables

* migrations

* code quality

* migration

* code

---------

Co-authored-by: g4ze <bhaiyajionline@gmail.com>

bump 6.0.3

updated docs

Bump django-ses from 4.0.0 to 4.1.0 in /requirements (#2342)

Bumps [django-ses](https://github.com/django-ses/django-ses) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/django-ses/django-ses/releases)
- [Changelog](https://github.com/django-ses/django-ses/blob/main/CHANGES.md)
- [Commits](django-ses/django-ses@v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: django-ses
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

rework prod/local traefik and add deletion of get-docker.sh

split traefik compose into base, prod and local

get-docker.sh deletion without sudo

change traefik compose naming

* remove unnecessary files

* remove print of compose files

* change doc

---------

Co-authored-by: Ubuntu <ubuntu@intelowldev.novalocal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants