-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Playbook: run only "free" analyzers #733
Comments
Can I take this issue up? From the looks of it, I might need to add minor changes to the backend and IntelOwl-ng (And probably PyIntelOwl) Any guidance before I proceed? |
yep you are right, this involves all the projects. I would suggest starting from the backend then the python client and lastly the frontend. This would probably be another flag the application should receive once it receives analysis requests from the user. (https://github.com/intelowlproject/IntelOwl/blob/master/api_app/api.py#L36) |
great! I think I should make a draft PR for this after I am done with the first backend things. |
I was thinking that to implement this issue, we can make it so that there is another option in I can make it so that if nothing is provided, It counts the analyzer to be running on its free version/is free by default. We can add this part in the documentation as well later on. This just seems like the simpler way for me. What do you say? If it would be required to be done this way, Which file should I refer to for making the edit? Preferably the place where |
I think it makes sense. There is a serializer which manages the data extracted from that JSON file. |
Thanks! Looking into this. |
Hey @mlodic! I forgot to update you on this back then. I reached out to @eshaan7 separately regarding this issue when I was assigned to it and we came to the conclusion that marking the analyzers as "free" might have been a hassle and some more discussion was needed to be done on moving forward with keeping this feature in mind. I would appreciate it if we can continue that discussion and see how we should proceed with solving this problem. One of the solutions that I propose to solve this is that we can add a new option key to But I need confirmation on this if we can even move forward with this because there is some clarification needed to confirm if all our analyzers do actually have a free version that we have adapted them for. If not then it seems like we would need to go through them one by one which seems to be the part that would cause the hassle. How should I proceed with this one? What do you folks say? |
I think that, in some way, this problem could also be solved by the "Playbook" feature #628 (we could pre-load a pre-configured playbook with only the free-analyzers) but that would certainly require more work to solve it. I think that every analyzer which needs an API key/login should not be considered as "free", while all the other yes. |
@0x0elliot Are you working on this? If not, @mlodic do you recommend me to work on this issue? |
you can, but it would require you to work from the branch |
I am not working on it. You can take care of this. |
After discussing more on this issue and the implementation that was tried in #927, we have come to the conclusion that we do not want to add extra parameters to the Moreover, the idea behind #628 was to provide a solution to this exact problem. So this will be solved by creating a playbook (once we have those) that contains all the free (without api key/login) analyzers. |
closed with #1238 |
updated: 15th March 2022
Idea / Motivation
The main use-case for this is the following example:
Pre-requisite(s)
Implementation Idea
This can be solved by creating a playbook that contains all the free (without api key/login) analyzers.
The text was updated successfully, but these errors were encountered: