Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT- Add GSoC Honeynet channel link + Github link to footer solves #955 #1217

Merged
merged 5 commits into from Oct 5, 2022

Conversation

viveknshah
Copy link
Contributor

@viveknshah viveknshah commented Oct 3, 2022

Description

React - Add GSoC Honeynet channel link + Github link to footer to fix #955

Related issues

#955

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new analyzer or connector was added, in which case:
    • Usage file was updated.
    • Advanced-Usage was updated (in case the analyzer/connector provides additional optional configuration).
    • Secrets were added in env_file_app_template, env_file_app_ci and in the Installation docs, if necessary.
    • If the analyzer/connector requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • If a File analyzer was added, its name was explicitly defined in test_file_scripts.py (not required for Observable Analyzers).
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • The tests gave 0 errors.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • The commits were squashed into a single one (optional, they will be squashed anyway by the maintainer)
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).

Important Rules

  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review

Real World Example

Please delete if the PR is for bug fixing.
Otherwise, please provide the resulting raw JSON of a finished analysis (and, if you like, a screenshot of the results). This is to allow the maintainers to understand how the analyzer works.

mlodic and others added 4 commits July 1, 2022 15:37
)

Bumps [django](https://github.com/django/django) from 3.2.14 to 3.2.15.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@3.2.14...3.2.15)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mlodic
Copy link
Member

mlodic commented Oct 4, 2022

hey thanks for your contribution! can you share a screenshot of the results?

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #1217 (98a9aeb) into develop (614cf6d) will decrease coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1217      +/-   ##
===========================================
- Coverage    77.28%   76.37%   -0.92%     
===========================================
  Files          193      183      -10     
  Lines         7238     6551     -687     
  Branches      1043      747     -296     
===========================================
- Hits          5594     5003     -591     
+ Misses        1244     1164      -80     
+ Partials       400      384      -16     
Impacted Files Coverage Δ
..._app/analyzers_manager/observable_analyzers/tor.py 67.30% <0.00%> (-8.89%) ⬇️
...pp/analyzers_manager/observable_analyzers/talos.py 71.11% <0.00%> (-4.57%) ⬇️
api_app/analyzers_manager/dataclasses.py 91.80% <0.00%> (-4.43%) ⬇️
.../analyzers_manager/observable_analyzers/maxmind.py 29.54% <0.00%> (-1.78%) ⬇️
intel_owl/settings/security.py 84.61% <0.00%> (-1.10%) ⬇️
api_app/analyzers_manager/controller.py 69.29% <0.00%> (-0.53%) ⬇️
intel_owl/settings/django.py 100.00% <0.00%> (ø)
intel_owl/settings/commons.py 100.00% <0.00%> (ø)
api_app/authentication/urls.py
api_app/authentication/apps.py
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 614cf6d...98a9aeb. Read the comment docs.

@viveknshah
Copy link
Contributor Author

updatedscreenIntelOwl

@mlodic here is the screenshot.

@mlodic mlodic changed the title FEAT- Add GSoC Honeynet channel link + Github link to footer #955 FEAT- Add GSoC Honeynet channel link + Github link to footer solves #955 Oct 5, 2022
@mlodic mlodic merged commit 15995c3 into intelowlproject:develop Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants