Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend - Investigations framework #2197

Merged
merged 29 commits into from Mar 25, 2024
Merged

Frontend - Investigations framework #2197

merged 29 commits into from Mar 25, 2024

Conversation

carellamartina
Copy link
Contributor

Description

Added analysis structure:

  • analysis table
  • analysis result
  • analysis flow

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. ("How to share a plugin with the community")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook by following this guide.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

Copy link
Contributor

@drosetti drosetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some little changes in the code, but nothing very relevant. You did a very great work:

  • I tested manually all the UI and also the edge cases and everything works
  • Good refactor of some components
  • Good structure of folders and files

api_app/serializers/job.py Outdated Show resolved Hide resolved
api_app/serializers/job.py Outdated Show resolved Hide resolved
frontend/src/components/analysis/result/analysisApi.jsx Outdated Show resolved Hide resolved
frontend/src/components/analysis/result/analysisApi.jsx Outdated Show resolved Hide resolved
frontend/src/components/analysis/result/analysisApi.jsx Outdated Show resolved Hide resolved
frontend/src/components/analysis/result/analysisApi.jsx Outdated Show resolved Hide resolved
frontend/src/components/analysis/result/analysisApi.jsx Outdated Show resolved Hide resolved
@drosetti
Copy link
Contributor

@carellamartina I merged a pr from another contributor, in the pr he created a new component for the cells for the plugin and job tables, this is the reason of the merge conflict. Feel free to ask me the desired UX of the tables cells if you want

@carellamartina carellamartina changed the title Frontend - Analysis framework Frontend - Investigations framework Mar 20, 2024
@drosetti
Copy link
Contributor

Waiting to better test websocket feature before merging this and add another huge feature to test

@mlodic mlodic linked an issue Mar 22, 2024 that may be closed by this pull request
1 task
@mlodic mlodic mentioned this pull request Mar 22, 2024
10 tasks
@drosetti drosetti merged commit 7ffaeff into develop Mar 25, 2024
11 of 12 checks passed
@drosetti drosetti deleted the frontend_analysis branch March 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigations (playbook workflows)
4 participants