Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Malware bazaar ingestor #2259
Malware bazaar ingestor #2259
Changes from 29 commits
e4f450f
8ed18f1
1d27bf5
6497a98
5ac7d17
b3d20a3
e359d83
87d9a3d
570c62e
e636124
90e30e6
9913052
30ca00a
8088cf4
5eda409
718ff36
ee48aaf
01bf119
0682935
bb6e436
ff7cf12
a60eab2
570b047
33fc56a
bb5e1c6
2164e00
a44d70e
d530b74
63544a4
33ffb01
8d946bb
ff7fa2a
f419a5a
9e7e6b3
1892e4d
7f7b814
75a450c
ad63bc0
7edd869
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 287 in api_app/classes.py
codefactor.io / CodeFactor
api_app/classes.py#L287
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add as comment the same description that you added in the
Parameter
model?Just so that if someone only reads this code, understand what is this parameter for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the
Parameter
calledsignatures
it is actually a secret, theconfig()
function would have assigned it to_signatures
in this class.Idk how this is working on your side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function imho should be split in 3 parts:
hashes
variableI would split this function in these 3 parts, to decrease its complexity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a timeout to the post request? Just in case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a timeout