Fixes #16: breaking up the project into different files and formatting code better #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x0elliot
changed the title
|
I also feel like we should have #14 added in as soon as we can so that we can safely move ahead. |
eshaan7
reviewed
Jan 28, 2022
| Token string | ||
| URL string | ||
| Certificate string | ||
| HTTPClient *http.Client |
There was a problem hiding this comment.
this should not be exposed so httpClient.
eshaan7
reviewed
Jan 28, 2022
| ) | ||
|
|
||
| // Struct for IntelOwl. | ||
| // Initiate it using Token, Instance, Certificate | ||
| type IntelOwlClient struct { | ||
| BaseURL string | ||
| Token string | ||
| URL string |
eshaan7
reviewed
Jan 28, 2022
| ) | ||
|
|
||
| // Struct for IntelOwl. | ||
| // Initiate it using Token, Instance, Certificate | ||
| type IntelOwlClient struct { | ||
| BaseURL string | ||
| Token string |
eshaan7
reviewed
Jan 28, 2022
| return response | ||
| type Response struct { | ||
| Code int | ||
| Data string |
eshaan7
reviewed
Jan 28, 2022
| type Response struct { | ||
| Code int | ||
| Data string | ||
| Success bool |
eshaan7
reviewed
Jan 28, 2022
| "net/http" | ||
| ) | ||
|
|
||
| type JobTag struct { |
eshaan7
reviewed
Jan 28, 2022
| file_name string `json:"file_name"` | ||
| file_mimetype string `json:"file_mimetype"` | ||
| status string `json:"status"` | ||
| tags JobTags `json:"tags"` |
eshaan7
reviewed
Jan 28, 2022
| no_of_connectors_executed string `json:"no_of_connectors_executed"` | ||
| } | ||
|
|
||
| type JobList []Job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if I can do the tests better and the commenting better. I will implement the feedback. The sooner I know what to improve here, The sooner can I make the right changes and get to implementing other API endpoints.