Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the job service object with unit tests! #36

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Adding the job service object with unit tests! #36

merged 3 commits into from
Jul 19, 2022

Conversation

fear-the-reaper
Copy link
Contributor

Description

Added `Job` service object which take cares of all `/api/job` endpoints alongside its unit tests!

Issues

#16

Type of change

list down the type of change

  • Bug fix
  • New feature (added a new endpoint or created)
  • Breaking fix (a bug fix or new feature that would cause exisiting functionality not to work as expected)

Checklist

  • if a new feature was added it passed all its (if made) test cases
  • if a bug fix was added it passed all its existing test cases

Important Rules

  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review

Please delete if the PR is for bug fixing.

@fear-the-reaper fear-the-reaper added the GSoC Issues that can be worked on before/during GSoC-2022 label Jul 17, 2022
@fear-the-reaper fear-the-reaper added this to In progress in GSoC' 22 go-intelowl via automation Jul 17, 2022
@fear-the-reaper fear-the-reaper self-assigned this Jul 17, 2022
sp35
sp35 reviewed Jul 17, 2022
View reviewed changes
gointelowl/job.go Outdated
Comment on lines 32 to 33
AnalyzerReports []Report `json:"analyzer_reports,omitempty"`
ConnectorReports []Report `json:"connector_reports,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm if these fields are empty or omitted in job response?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are in the job response. However, they are not included in jobList.

gointelowl/job.go Outdated Show resolved Hide resolved
gointelowl/job.go Show resolved Hide resolved
@fear-the-reaper fear-the-reaper mentioned this pull request Jul 17, 2022
Closed
@sp35 sp35 merged commit 5175394 into main Jul 19, 2022
GSoC' 22 go-intelowl automation moved this from In progress to Done Jul 19, 2022
@sp35 sp35 deleted the job_service_object_with_unit_test branch July 19, 2022 15:41
fear-the-reaper added a commit that referenced this pull request Jul 21, 2022
@fear-the-reaper
Adding the job service object with unit tests! (#36)
08fc2f9 
* Adding the job service object with unit tests!

* Adding requested changes: divided the job struct into 2 types
@fear-the-reaper fear-the-reaper mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sp35 sp35 sp35 approved these changes

@eshaan7 eshaan7 Awaiting requested review from eshaan7

Assignees

@fear-the-reaper fear-the-reaper

Labels
GSoC Issues that can be worked on before/during GSoC-2022
Projects
GSoC' 22 go-intelowl
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fear-the-reaper @sp35