Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding TLP as an enum and adding it to relevant service objects #39

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Adding TLP as an enum and adding it to relevant service objects #39

merged 1 commit into from
Jul 19, 2022

Conversation

fear-the-reaper
Copy link
Contributor

Description

Added the `TLP` attribute as an enum which can properly be converted from a JSON to a struct and vice versa

Issues

#38

Type of change

list down the type of change

  • Bug fix
  • New feature (added a new endpoint or created)
  • Breaking fix (a bug fix or new feature that would cause exisiting functionality not to work as expected)

Checklist

  • if a new feature was added it passed all its (if made) test cases
  • if a bug fix was added it passed all its existing test cases

Important Rules

  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review

Please delete if the PR is for bug fixing.

@fear-the-reaper fear-the-reaper added the GSoC Issues that can be worked on before/during GSoC-2022 label Jul 18, 2022
@fear-the-reaper fear-the-reaper self-assigned this Jul 18, 2022
sp35
sp35 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@sp35 sp35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sp35 sp35 merged commit f5e201d into main Jul 19, 2022
@sp35 sp35 deleted the adding_enum_to_tlp_attribute branch July 19, 2022 15:45
fear-the-reaper added a commit that referenced this pull request Jul 21, 2022
@fear-the-reaper
Adding TLP as an enum and adding it to relevant service objects (#39)
04024d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sp35 sp35 sp35 approved these changes

@eshaan7 eshaan7 Awaiting requested review from eshaan7

Assignees

@fear-the-reaper fear-the-reaper

Labels
GSoC Issues that can be worked on before/during GSoC-2022
Projects
GSoC'22 - go-intelowl
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fear-the-reaper @sp35