Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the me endpoints with its respective unit tests #57

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Adding the me endpoints with its respective unit tests #57

merged 3 commits into from
Sep 5, 2022

Conversation

fear-the-reaper
Copy link
Contributor

Description

Adding me endpoints with its unit tests

Issues

add the related issue(s) your change tackles

Type of change

list down the type of change

  • Bug fix
  • New feature (added a new endpoint or created)
  • Breaking fix (a bug fix or new feature that would cause exisiting functionality not to work as expected)

Checklist

  • if a new feature was added it passed all its (if made) test cases
  • if a bug fix was added it passed all its existing test cases

Important Rules

  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review

Please delete if the PR is for bug fixing.

@fear-the-reaper fear-the-reaper self-assigned this Sep 4, 2022
@fear-the-reaper fear-the-reaper added the enhancement New feature or request label Sep 4, 2022
sp35
sp35 approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@sp35 sp35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

gointelowl/me.go Outdated Show resolved Hide resolved
gointelowl/me.go Show resolved Hide resolved
tests/userService_test.go Outdated Show resolved Hide resolved
@sp35 sp35 merged commit 598ed60 into main Sep 5, 2022
@sp35 sp35 deleted the me_endpoints branch September 5, 2022 13:22
@fear-the-reaper fear-the-reaper mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sp35 sp35 sp35 approved these changes

Assignees

@fear-the-reaper fear-the-reaper

Labels
enhancement New feature or request
Projects
GSoC'22 - go-intelowl
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fear-the-reaper @sp35