-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong result in registered depth image on realsense D435if using rs_rgbd.launch (ROS1) #3027
Comments
Hi @Alessio-Parmeggiani Thanks very much for your report about registered depth in the rs_rgbd launch file and the sharing of your method of using When align_depth is true, the librealsense SDK's align processing block automatically compensates for differences in resolution between depth and color. |
Thank you for answering @MartyG-RealSense. |
As the RealSense ROS1 wrapper has ceased development (the ROS2 wrapper continues to be updated), your |
Hi @Alessio-Parmeggiani Do you require further assistance with this case, please? Thanks! |
No I don't require further assistance, I can close the issue. Thank you! |
You are very welcome, @Alessio-Parmeggiani - thanks very much for the update! |
Hi, I noticed that using the rs_rgbd.launch file from the ROS1 branch and
![Wrong result](https://private-user-images.githubusercontent.com/57560488/308981784-9ac04fc1-5383-4fdc-a18f-9ac4383e5a27.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3MTA2NzYsIm5iZiI6MTcxOTcxMDM3NiwicGF0aCI6Ii81NzU2MDQ4OC8zMDg5ODE3ODQtOWFjMDRmYzEtNTM4My00ZmRjLWExOGYtOWFjNDM4M2U1YTI3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjMwVDAxMTkzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTViZGUzZDM5YTYwMDM2ZDE2MmI0Yzg3NDJkYmFjYTJjZjliOWU5NTNlNGJkY2M2OTIzNTg5NGQ1ZDU0Y2YxMDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.MhGfelbvurdkwp8gy6pDkg5gYvXGtYBOGVzNAktT1rs)
align_depth=false
the output registered depth image has some problems.In the following image I show the rgb image, the depth image and the registered depth computed by the launch file.
The problem occurs because the register node from depth_image_proc needs an additional parameter
fill_upsampling_holes=true
.Otherwise the RGB image has a higher resolution and the pixels with no depth information will not be filled.
This is the result with the
![Correct result](https://private-user-images.githubusercontent.com/57560488/308981870-64510af7-37a7-4bda-8f84-5af0c4b5923c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3MTA2NzYsIm5iZiI6MTcxOTcxMDM3NiwicGF0aCI6Ii81NzU2MDQ4OC8zMDg5ODE4NzAtNjQ1MTBhZjctMzdhNy00YmRhLThmODQtNWFmMGM0YjU5MjNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjMwVDAxMTkzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEzNDI1MGVjOTkxZjI0Yzc3NWU3M2ZmM2UxNzM5ZWQ5MmRmZTY1MTg1YzRiNjJhMGExZTM0YzhhMDY2ZDMwZWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.I3_VC97JbFRv4DgQaMgeUCko7GBtHN2-ntaiNJmgnbw)
fill_upsampling_holes=true
parameter set in the launch file.Tested using Ubuntu 22 and ROS2 but the parameter is the same in ROS1 Noetic.
The text was updated successfully, but these errors were encountered: