Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Switch to snap-plugin-lib-go #59

Merged
merged 2 commits into from
Dec 22, 2016

Conversation

denismakogon
Copy link
Contributor

Switching from snap/core and snap/plugin to snap-plugin-lib-go

Summary of changes:

  • updating glide with new dependency
  • changing imports wherever it is necessary

@denismakogon
Copy link
Contributor Author

@kindermoumoute i'm not able to say that this code works because i've faced with problem that i'm not capable to overcome:

ubuntu@ubuntu:/opt/stack/functions/src/github.com/intelsdi-x/snap-plugin-collector-docker$ make all
bash -c "./scripts/build.sh /opt/stack/functions/src/github.com/intelsdi-x/snap-plugin-collector-docker"
2016-12-21 14:52:32 UTC [     info] project path: /opt/stack/functions/src/github.com/intelsdi-x/snap-plugin-collector-docker
2016-12-21 14:52:32 UTC [     info] plugin name: snap-plugin-collector-docker
2016-12-21 14:52:32 UTC [     info] building plugin: snap-plugin-collector-docker
# github.com/intelsdi-x/snap-plugin-collector-docker/vendor/github.com/intelsdi-x/snap-plugin-lib-go/v1/plugin/rpc
vendor/github.com/intelsdi-x/snap-plugin-lib-go/v1/plugin/rpc/plugin.pb.go:768: undefined: grpc.SupportPackageIsVersion3
Makefile:37: recipe for target 'all' failed
make: *** [all] Error 1

Can you provide any help on it?

@nanliu
Copy link
Contributor

nanliu commented Dec 21, 2016

@denismakogon, please rebase your PR against the current master. I think you can simply copy the new glide.yaml and use the command glide update to resolve the new dependencies. There will be some changes required by the new plugin lib, but the error message will be much more informative. Most of them should be along the lines of updating mt.Namespace().String() to mt.Namespace.String().

@denismakogon denismakogon changed the title Switch to snap-plugin-lib-go [WIP] Switch to snap-plugin-lib-go Dec 22, 2016
@denismakogon denismakogon force-pushed the switch-to-pluginlib branch 2 times, most recently from 44a9edb to 665f121 Compare December 22, 2016 09:17
 Step 1: updating dependencies
 Step 2: replease snap/{plugin, core} with intelsdi-x/snap-plugin-lib-go
@denismakogon denismakogon changed the title [WIP] Switch to snap-plugin-lib-go Switch to snap-plugin-lib-go Dec 22, 2016
@denismakogon
Copy link
Contributor Author

@kindermoumoute ready for review.

@marcin-krolik
Copy link
Collaborator

LGTM

As the side note, I'm currently working on heavy refactoring of docker collector.
First, no more expensive collects for metrics which are not requested. Additionally, it will recognize cgroupfs diver properly. Last but not least is removal of dependency to openlibcontainers/runc.

@marcin-krolik marcin-krolik merged commit 4cfc2ce into intelsdi-x:master Dec 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants