Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

missing some metrics for intel/psutil/vm/ #21

Closed
msrba opened this issue Jun 7, 2016 · 7 comments
Closed

missing some metrics for intel/psutil/vm/ #21

msrba opened this issue Jun 7, 2016 · 7 comments
Labels

Comments

@msrba
Copy link

msrba commented Jun 7, 2016

I use snap-plugin-collector-psutil with snap version v0.13.0 for Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHz. I missing the metric "intel/psutil/vm/shared".

/opt/snap/bin/snapctl metric list | grep /intel/psutil/vm
/intel/psutil/vm/active                      6
/intel/psutil/vm/available                   6
/intel/psutil/vm/buffers                     6
/intel/psutil/vm/cached                      6
/intel/psutil/vm/free                        6
/intel/psutil/vm/inactive                    6
/intel/psutil/vm/total                       6
/intel/psutil/vm/used                        6
/intel/psutil/vm/used_percent                6
/intel/psutil/vm/wired                       6
@IRCody
Copy link

IRCody commented Oct 5, 2016

@msrba: Sorry for the delayed reply.

What OS are you using? the shared metric is Platform specific. For example I don't believe it's available on OSX.

@IRCody
Copy link

IRCody commented Oct 11, 2016

@msrba: I'm going to close this issue due to inactivity but if you come back and can provide more info please respond here with an @ircody and I will re-open.

@IRCody IRCody closed this as completed Oct 11, 2016
@msrba
Copy link
Author

msrba commented Oct 11, 2016

We use snap on Ubuntu 14.04 and 16.04 both have the issue.

@IRCody IRCody removed the tracked label Oct 11, 2016
@IRCody
Copy link

IRCody commented Oct 11, 2016

Thanks for the info! I'll re-open. I can test on ubuntu 14.04 tomorrow.

@IRCody IRCody reopened this Oct 11, 2016
@IzabellaRaulin
Copy link
Contributor

I confirmed that the metric /intel/psutil/vm/shared is missing and what is more, it does not depend on system, just creating this metricType is missing - see psutil/mem.go#L78. I will take a look on that.

@IzabellaRaulin
Copy link
Contributor

IzabellaRaulin commented Oct 11, 2016

I found out that this field has been removed from github.com/shirou/gopsutil/mem in commit 4438159, on Feb 17. See in description:

Document + add tests for for mem.VirtualMemory()
This change changes and documents the (previously undocumented) behavior of Used
to "RAM used by programs".

We also remove the undocumented and unused Shared field of that struct.

snap-plugin-collector-psutil uses that mem structure from github.com/shirou/gopsutil/mem and calls mem.VirtualMemory() and retrieves appropriate values from it, see psutil/mem.go.

@IRCody
Copy link

IRCody commented Oct 11, 2016

Thanks @IzabellaRaulin for tracking that down. It seems like the README.md should be updated to reflect these changes.

@nanliu nanliu closed this as completed in cbaff27 Dec 20, 2016
nanliu added a commit that referenced this issue Dec 20, 2016
Fix #21 remove shared metric from documentation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants