Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Commit

Permalink
Changes after the PR
Browse files Browse the repository at this point in the history
  • Loading branch information
albertpastrana committed Aug 4, 2015
1 parent b360c03 commit c214b9b
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 10 deletions.
24 changes: 15 additions & 9 deletions README.md
Expand Up @@ -27,23 +27,29 @@ the following line (remember to replace 1.0 with the latest version):
### In your code

Gander provides a single object and a single method to access its functionality
and it's pretty straight forward and intuitive to use.
and it's pretty straightforward and intuitive to use.

This three lines of code, for example, would download the url specified (using
This three lines of code, for example, will download the specified url (using
Guava) and extract the page information from the raw html:
```scala
val url = "http://engineering.intenthq.com/2015/03/what-is-good-code-a-scientific-definition/"
val url = "http://engineering.intenthq.com"
val rawHTML = Resources.toString(new URL(url), charset)
println(Gander.extract(rawHTML))

```

You can find more examples in our tests.

## Collaborate & Philosophy
Keep it simple and make 1 thing
Remove the code that was doing other stuff (downloading)
Removed images for simplicity, we may want to add it in the future.
The interface is so simple that can be easily used from Java as well.
## Philosophy

Please, feel free to fork the repo and raise a PR.
The idea behind Gander is to do one thing and do it well. That's why we've
removed some of the features that were not related to its core functionality.

This project will always try to be better at extracting data and information
from webpages. But it won't deal with other (probably related but not core)
functionalities (like downloading html from urls).

## Collaborate

Please, feel free to raise an issue, fork the repo, send pull requests...
Any idea or improvement will be welcome.
2 changes: 1 addition & 1 deletion src/it/scala/com/intenthq/gander/GanderIT.scala
Expand Up @@ -25,7 +25,7 @@ class GanderIT extends Specification {
pageInfo.publishDate must_== date.map(DateTime.parse(_).toDate)
pageInfo.cleanedText.get must startWith(content)
pageInfo.canonicalLink.map( _ must_== url).getOrElse(1 must_== 1)
pageInfo.links must containAllOf(links)
pageInfo.links must_== links
}

"intenthq" >> {
Expand Down

0 comments on commit c214b9b

Please sign in to comment.