This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Init repo list #24
Merged
Init repo list #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2019
Closed
nathankleyn
suggested changes
Apr 8, 2019
| reference, | ||
| }) | ||
| .map(|x| { | ||
| x.0.map(Binary::from) |
There was a problem hiding this comment.
Don't mind if we fix in another PR — but would be inclined to use a struct here instead of a tuple, x.0 is kind of gross because it's hard to see from the code what it is that is being operated on.
There was a problem hiding this comment.
I'm usually anti-tuple so happy to refactor now that you've called me out on it 😛
There was a problem hiding this comment.
Wait, got mixed up, was thinking of the tuple I used here. Though in this case it's necessary for building the map.
Line 48 in de7bf87
Given the sprint ends tomorrow I'll pick this up in a future PR?
nathankleyn
suggested changes
Apr 8, 2019
|
Fixed |
First it populates the list based on the repos found in the repo_root directory specified as parameter. Later, when calling the endpoint, the name of the repo is checked against that repo list and it will only accept requests with a valid repository as parameter. This commit should fix the vulnerability mentioned in #12. Still need to add some tests on the code and some other stuff mentioned as TODOs. Signed-off-by: Albert Pastrana <albert.pastrana@intenthq.com>
Makes `reference` parameter when requesting files optional, defaults to master
Replace mutable loop with functional code Add handling for more failure cases Silently discard repos that failed to load
Make error message more specific Make dependency version more specific Make cloning of data explicit
kittsville
force-pushed
the
init-repo-list
branch
from
5ba23a8
to
0d72872
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricts git repos to a pre-defined selection, as per #12. Worth noting there's no tests for
load_repos. Do we want to test this method and if so how?This PR also: