Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Expand Snowflake model attributes #622

Closed
1 task done
FayeDel opened this issue Mar 7, 2022 · 1 comment
Closed
1 task done

[REQUEST] Expand Snowflake model attributes #622

FayeDel opened this issue Mar 7, 2022 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@FayeDel
Copy link
Collaborator

FayeDel commented Mar 7, 2022

Describe the feature.

Currently, all the attributes (not counting with @property) are hash()/int()/str().
I've left equality Snowflake model checking alongside greater/less than (with and without equal to) up for debate since v4.0 beta was released, so I'm raising the respective issue for feedback if this needs to be implemented (This isn't per API schema, hence the lack of implementation, but I think a lot of the community would appreciate the extension.

Code of Conduct

  • I agree to follow the contribution requirements.
@FayeDel FayeDel added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 7, 2022
@Catalyst4222
Copy link
Contributor

I believe that __eq__ is needed to be able to compare the same id from multiple sources (like message id vs components origin message id)
__gt__ and __lt__ probably have fewer use cases, but I don't see any reason not to add them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Complete
Development

No branches or pull requests

4 participants