feat: create basic functionality for Extensions

[Catalyst4222]

Expands Extension.new and adds new functions to mimic client decorators

About

This pr adds in basic functionality for the Extension class, along with decorators for commands/components/listeners
Marked as a draft because some things are missing, like properly removing commands on removal of the Extension
Any suggestions on improvements are welcome

Checklist

• I've ran pre-commit to format and lint the change(s) made.
• I've checked to make sure the change(s) work on 3.8.6 and higher.
• This fixes/solves an Issue.
  • (If existent): [MISC] Revamping the cogs/extension framework
• I've made this pull request for/as: (check all that apply)
  • Documentation
  • Breaking change
  • New feature/enhancement
  • Bugfix

[Catalyst4222]

I would like someone to double check that everything works, and I'm not just hallucinating a lack of errors. It would probably be a good idea to simplify some of the code, I got it working but it doesn't look the nicest

[i0bs]

Delta and I will test this code when this PR is marked ready for reviewing

[FayeDel]

There's support for @client.component, @Client.command, etc using these, but what about @Client.autocomplete?

[i0bs]

No support for modals either

[i0bs]

LGTM. Please pre-commit though.

[i0bs]

This is LGTM, I think we're finally ready to go ahead and merge this. I'll be leaving the last approval on this for @DeltaXWizard , but all of these changes look good on my end.

[FayeDel]

You may need to run pre-commit again after new pending changes, I'll test afterwards though :)
(Code looks good, I have no objections, I just need to test the thing before I approve)

[mAxYoLo01]

After some more tests, I figured out that there still are a few problems to address:

1. When loading any extension after bot.start(), all commands that are initialized outside of a cog (for example initialized in the main launch file) will all disappear from the Slash Commands Menu. Commands of the loaded cog will not be removed from the Menu but will not respond either.
2. After unloading an extension, the commands from this extension are not removed, and can still be accessed from the Slash Commands Menu.

Feel free to ask me if you need some example code to recreate these issues.

[Toricane]

I don't think you are supposed to load extensions after bot.start()
But it does seem like an issue, shouldn't be wiping the ones in the main file

[Catalyst4222]

I want to test again, just to make sure I fixed the breaking changes from the last patch

[mAxYoLo01]

I don't think you are supposed to load extensions after bot.start() But it does seem like an issue, shouldn't be wiping the ones in the main file

Didn't know it might be a possibility that it shouldn't be loaded afterwards, in fact I was creating a Slash Command that allows the user to un/re/load cogs directly via Discord. I've previously done it with d.py, so I thought that it would be a feature that i.py should also have.

[EdVraz]

Afaik fl0w wanted something like hot reload for cogs at first so it should be possible tho shouldn't it?

[Toricane]

Afaik fl0w wanted something like hot reload for cogs at first so it should be possible tho shouldn't it?

Oh ok never mind then

[Catalyst4222]

I don't know how to do pre-commit
I do git add <changes>, black.exe ., isort.exe ., flake8.exe . and do the changes, but it still failes

[Catalyst4222]

[mAxYoLo01]

Alright there is still the problem that "global" commands (not initialized in cogs) disappear after loading any cog on my side. The other issues have been fixed though.

[Catalyst4222]

"global" commands (not initialized in cogs) disappear after loading any cog on my side

I'm unable to reproduce this. All commands outside of the cog remain usable, and any inside get added/removed as the cog gets loaded/unloaded. The only reason I can think of for it happening would be global commands, as I've only been testing in the guild scope. I'll try global commands now, but I don't expect a difference

[mAxYoLo01]

The only reason I can think of for it happening would be global commands, as I've only been testing in the guild scope.

Oh my bad on this one, I formulated badly my previous message. In fact, I also have tried it only with a guild scope.
Weird that we don't have the same behaviour, on my hand whenever I load/reload a cog, all the commands outside of this cog disappear.

[Catalyst4222]

I've recreated the missing commands issue, and it seems to only happen when a cog is unloaded then reloaded in quick succession. Any ideas as to why or where this is happening is welcome

[i0bs]

I'll be moving through with merging this to unstable, I'm looking to hit a feature lock on getting extensions in rather soon and we can always make revisions with the pull request being brought in. For any relating concerns to this, I advise others to create an Issue or make a mention of it in the #unstable-dev channel in our support server.