Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Revamping the cogs/extension framework #425

Closed
V3ntus opened this issue Jan 12, 2022 · 1 comment
Closed

[MISC] Revamping the cogs/extension framework #425

V3ntus opened this issue Jan 12, 2022 · 1 comment
Labels
pending Pending approve question Further information is requested

Comments

@V3ntus
Copy link
Contributor

V3ntus commented Jan 12, 2022

As per James, Delta, Catalyst, etc. conversation in Discord, creating this issue just to track progress accordingly on the Git repo. There were lots of people interested in contributing it seems

James:

the problem we have is that we're trying to make a decorator from the client work in a different class, and unless we do some incredibly disgusting functools wrapper hacky logic, it's not possible to base a decorator off of a class attr
that's what makes it really hard for us

but i saw Joe [@V3ntus] do something with making a method external from both classes and having it simply call the client's event method we use, which makes it very easy to use

i'll probably do something like this but in our decor file and organize it so it can differentiate between listeners and callback wraps we use

@V3ntus V3ntus added the question Further information is requested label Jan 12, 2022
@FayeDel FayeDel added the pending Pending approve label Jan 15, 2022
@EepyElvyra
Copy link
Contributor

Closing this issue because #428 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Pending approve question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants