Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add helper methods to the gw member model #492

Merged
merged 19 commits into from
Mar 17, 2022
Merged

feat: Add helper methods to the gw member model #492

merged 19 commits into from
Mar 17, 2022

Conversation

EdVraz
Copy link
Contributor

@EdVraz EdVraz commented Feb 8, 2022 •
edited
Loading

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EdVraz EdVraz added the enhancement New feature or request label Feb 8, 2022
@EdVraz EdVraz requested a review from FayeDel February 8, 2022 18:57
@EdVraz EdVraz changed the title feat: Add helper methods to the gw membe model feat: Add helper methods to the gw member model Feb 8, 2022
@EdVraz EdVraz self-assigned this Feb 10, 2022
@EdVraz EdVraz linked an issue Feb 14, 2022 that may be closed by this pull request
[REQUEST] implement helper methods to the gw member model #490
Closed
FayeDel
FayeDel requested changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@FayeDel FayeDel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change :ivar List[Member] members: The members of the event. to List[GuildMember] in line 580 (It won't let me select the line)

@EdVraz EdVraz requested a review from FayeDel February 14, 2022 20:14
@EdVraz EdVraz enabled auto-merge (squash) February 21, 2022 19:46
@EdVraz EdVraz merged commit c68ebe1 into interactions-py:unstable Mar 17, 2022
@EdVraz EdVraz deleted the add_helper_meths_to_gw_models branch March 17, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i0bs i0bs i0bs left review comments

@FayeDel FayeDel FayeDel approved these changes

Assignees

@EdVraz EdVraz

Labels
enhancement New feature or request
Projects
core
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST] implement helper methods to the gw member model
3 participants
@EdVraz @FayeDel @i0bs