fix: Catch CancelledError/Exception in start()
#852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Messed up my commit, oopsies. Change is valid though |
EdVraz
reviewed
Jun 12, 2022
EdVraz
approved these changes
Jun 12, 2022
Toricane
changed the title
CancelledError/Exception in start()CancelledError/Exception in start()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Catch and reraise exceptions that occur in
Client.start(). I honestly don't know why exceptions weren't getting raised beforehand, but this now allows you to cancel the task.Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.