Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch CancelledError/Exception in start() #852

Merged
merged 1 commit into from
Jun 12, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions interactions/client/bot.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import re
import sys
from asyncio import get_event_loop, iscoroutinefunction
from asyncio import CancelledError, get_event_loop, iscoroutinefunction
from functools import wraps
from importlib import import_module
from importlib.util import resolve_name
Expand Down Expand Up @@ -135,7 +135,10 @@ def latency(self) -> float:

def start(self) -> None:
"""Starts the client session."""
self._loop.run_until_complete(self._ready())
try:
self._loop.run_until_complete(self._ready())
except (CancelledError, Exception) as e:
V3ntus marked this conversation as resolved.
Show resolved Hide resolved
raise e from e

def __register_events(self) -> None:
"""Registers all raw gateway events to the known events."""
Expand Down