Add sendAsync functions to web push service to support non-blocking calls #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have now removed the third party dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did add non blocking async (suspend) function as an alternative to the blocking non async functions.
I had to add one dependency to support this workflow (kotlinx-coroutines-core), which is an official Kotlin dependency from JetBrains. This did increase the jar file by 2 KB (from 24 KB to 26 KB), which shouldn't be a large impact (this should still be considered lightweight). Only the part with the zero dependency wouldn't be true, but it would only be 1 first party dependency. If you don't like this, you can just reject my request.