SignedHeader should contain commit #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Commit needed for lite client and RPC endpoint - Commit does not always refer to the last commit
liamsi
added a commit
that referenced
this pull request
Sep 25, 2019
2DC46AD76277039F1B65FE3C7F2064788B1C12FE701CFE7EC93F751586A48781) will add a test after #42 gets merged
liamsi
added a commit
that referenced
this pull request
Sep 25, 2019
2DC46AD76277039F1B65FE3C7F2064788B1C12FE701CFE7EC93F751586A48781) will add a test after #42 gets merged
ebuchman
approved these changes
Oct 3, 2019
liamsi
added a commit
that referenced
this pull request
Dec 10, 2019
* Use concrete basic types for time, hash, bytes, validator id * cargo fmt * into_iter unnecessarily moves the Vec (clippy) * Resolve a bunch of clippy warnings about: https://rust-lang.github.io/rust-clippy/master/#try_err * make the lite client a module instead of a separate crate: This is just the simplest way to move forward implementing the traits of the lite package. There are alternatives: We do not want a create a circular dependency between lite and tendermint (which does not even compile). To avoid this we could: 1) make lite a module of tendermint, or, 2) replicate a lot of the types of the tendermint crate in the lite package (e.g. Time, Ids etc), or 3) have a dependency from tendermint to the lite package only (but then the trait impls do need to live in the lite crate instead with the types in the tendermint crate directly). * add amino type for header Version * working towards hashing the header: conversion between fields and their respective amino types, and, directly encode some * Header::hash works now (tested against JSON fixture only and yields: 2DC46AD76277039F1B65FE3C7F2064788B1C12FE701CFE7EC93F751586A48781) will add a test after #42 gets merged * remove todo * implement lite::Validator trait * implement lite::ValidatorSet trait * implement lite::Vote trait * bring back BufMut; fix clippy warnings * Address some review comments: - Consistency: Rename encode_bytes to bytes_enc - remove redundant return statement * Consistency: From<&vote::Vote> same order as the fields in the struct * deduplicate encoding a hash: add a helper * deduplicate encoding hashes and varints: add a helper for each * simplify sign_bytes to return Vec<u8> instead of passing in a BufMut * Add test for lite::Header.hash() in rpc tests * wrap the CanonicalVote in a struct that contains the validator ID and the signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #38 and #41