Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug using 'scalar' inappropriately in cart route #40

Closed
SysPete opened this issue Nov 12, 2014 · 1 comment
Closed

bug using 'scalar' inappropriately in cart route #40

SysPete opened this issue Nov 12, 2014 · 1 comment
Labels

Comments

@SysPete
Copy link
Member

SysPete commented Nov 12, 2014

@murwiz added this to #25. New issue created to track this.

I think there's a bug in Interchange6::Routes::Cart:

    if (scalar($input)) {

I think you meant "ref($input)". I'm attempting to rewrite this code for my own purposes, then maybe you can look it over.

@SysPete
Copy link
Member Author

SysPete commented Nov 12, 2014

Since cart route only accepts a single sku param right now (or at least can only handle a single one) this is currently harmless. Keeping this bug open until decision is made on how we will handle post with multiple products (see #25).

SysPete added a commit that referenced this issue Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant