feat(rendercontenttype): include "sys" with content type ID in the generated interface #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2019 12:51
…nerated interface It's helpful to be able to inspect an entry's `sys.contentType.sys.id` field to see what type it is, especially when a link can be one of many types. This makes the types support such a check. BREAKING CHANGE: Users who use one content type's interface to accept another content type in a function (for example, if one content type is a superset of another one) will need to use a union type and allow all possible content types now.
stevenpetryk
commented
Aug 22, 2019
| `) | ||
| type CONTENTFUL_DEFAULT_LOCALE_CODE = \\"en-US\\" | ||
| " | ||
| `) |
There was a problem hiding this comment.
Not sure what caused jest to start rendering nicely-indented inline snapshots, but I'm a big fan.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's helpful to be able to inspect an entry's
sys.contentType.sys.idfield to see what type it is,especially when a link can be one of many types. This makes the types support such a check.
BREAKING CHANGE: Users who use one content type's interface to accept another content type in a function (for example, if one content type is a superset of another one) will need to use a union
type and allow all possible content types now.