Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate new client with a credentials object? #15

Closed
pcothenet opened this issue Aug 25, 2015 · 1 comment · Fixed by #18
Closed

Instantiate new client with a credentials object? #15

pcothenet opened this issue Aug 25, 2015 · 1 comment · Fixed by #18

Comments

@pcothenet
Copy link
Contributor 

new Intercom.Client({
    apiKey: 'apiKey',
    appId: 'appId'
}

is generally less error-prone and more readable than

new Intercom.Client('app_id', 'api_key');

Not super critical, but easier to change while there are not too many users.
@bobjflong bobjflong mentioned this issue Aug 27, 2015
Merged
@matsilva
Copy link

matsilva commented Oct 2, 2015

if this is merged why isn't this in the main docs?

matsilva added a commit to matsilva/intercom-node that referenced this issue Oct 2, 2015
@matsilva
Updated README Client instantiation
4416b5f 
This is based on the merge of intercom#15.
@matsilva matsilva mentioned this issue Oct 2, 2015
Closed
hypeofpipe pushed a commit that referenced this issue Jan 18, 2022
@johnnynader
fix gitignore and add yarn release (#15)
4796d49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow err params in callbacks and support objects in Client intercom/intercom-node
2 participants
@pcothenet @matsilva