Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CreateCompanyData fields optional #346

Closed
sapkus opened this issue Feb 6, 2023 · 4 comments · Fixed by #367
Closed

Make CreateCompanyData fields optional #346

sapkus opened this issue Feb 6, 2023 · 4 comments · Fixed by #367

Comments

@sapkus
Copy link

sapkus commented Feb 6, 2023

Woudl be nice to have company fields optional, as it is in contact modal.

Current code:

interface CreateCompanyData {
    createdAt: Timestamp;
    companyId: string;
    name: string;
    monthlySpend: number;
    plan: string;
    size: number;
    website: string;
    industry: string;
    customAttributes: JavascriptObject;
}

Desired:

interface CreateCompanyData {
    createdAt?: Timestamp;
    companyId: string;
    name?: string;
    monthlySpend?: number;
    plan:? string;
    size?: number;
    website?: string;
    industry?: string;
    customAttributes?: JavascriptObject;
}

@colmdoyle
Copy link
Contributor

Let me double check which of these are optional on the relevant endpoints, but assuming they're actually optional value (as I suspect they are), then yes, we can 100% make this change.

@charsleysa
Copy link

@colmdoyle has there been any update on this?

@colmdoyle
Copy link
Contributor

Sorry, no!

We're not fundamentally opposed to it, just as with many things, we have competing priorities.

@co-sic
Copy link

co-sic commented Jun 12, 2023

@colmdoyle we would also like to see that change, any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants