Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the company fields optional #367

Merged
merged 9 commits into from
Jul 10, 2023
Merged

Make the company fields optional #367

merged 9 commits into from
Jul 10, 2023

Conversation

colmdoyle
Copy link
Contributor

Why?

The only actual required field in this call in company_id, so reflect that in the type.

How?

Updated the interface

closes #346

@colmdoyle colmdoyle enabled auto-merge July 7, 2023 16:27
Colm Doyle added 3 commits July 7, 2023 17:56
listAllActivityLogs can take a long time to execute, so limit the search
@colmdoyle
Copy link
Contributor Author

This is now getting pretty unwieldy, I'm going to break it out into a few different PRs

@colmdoyle colmdoyle marked this pull request as draft July 10, 2023 10:46
auto-merge was automatically disabled July 10, 2023 10:46

Pull request was converted to draft

@colmdoyle colmdoyle marked this pull request as ready for review July 10, 2023 11:08
@colmdoyle colmdoyle merged commit f478851 into master Jul 10, 2023
3 checks passed
@colmdoyle colmdoyle deleted the optional-fields-346 branch July 10, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CreateCompanyData fields optional
2 participants