Upgrade to PHP 7.1+ #271
Merged
Upgrade to PHP 7.1+ #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielAnca
force-pushed
the
ga/php-7
branch
3 times, most recently
from
5f814bf
to
1fd3e3f
Compare
SeanHealy33
reviewed
Jan 9, 2019
| @@ -7,8 +7,7 @@ | |||
| convertNoticesToExceptions="true" | |||
| convertWarningsToExceptions="true" | |||
| processIsolation="false" | |||
| stopOnFailure="false" | |||
| syntaxCheck="false"> | |||
There was a problem hiding this comment.
why have we removed this syntax check?
There was a problem hiding this comment.
That argument has been removed from the last versions of PHPUnit, see the answer by PHPUnit author here. I googled all I could and I can't even find what exactly that was doing 😕
SeanHealy33
previously approved these changes
Jan 9, 2019
3 tasks
DavidGarciaCat
previously approved these changes
Jan 14, 2019
Co-Authored-By: GabrielAnca <GabrielAnca@users.noreply.github.com>
GabrielAnca
dismissed stale reviews from DavidGarciaCat and SeanHealy33
via
43dd320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
PHP 5.6 and 7.0 are no longer supported. We should only support active versions (7.1, 7.2 and 7.3 at the time of writing)
How?
This PR drops the support for PHP < 7.1 and splits the circle tests to ensure it works in all of those versions.
PHPUnit 4 is both unsupported and not compatible with PHP >=7.2. PHPUnit 7 is compatible with php 7.1 to 7.3, so I'm upgrading to that version.