Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended error handling and added support for finding admin by ID #170

Merged
merged 4 commits into from
Oct 24, 2017

Conversation

tanasegabriel
Copy link
Contributor

@tanasegabriel tanasegabriel commented Oct 16, 2017

Added support for the following error codes:

  • client_error
  • type_mismatch
  • not_restorable
  • server_error
  • token_not_found
  • token_revoked
  • token_blocked
  • token_expired
  • admin_not_found

Reference - https://developers.intercom.com/v2.0/reference#error-codes
Fix for #161

Added support for finding admins by id (fix for #159):
intercom.admins.find(id="123456")

@tanasegabriel tanasegabriel changed the title Extend error handling Extend error handling and added support for finding admin by ID Oct 16, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.842% when pulling fcdce48 on tanasegabriel:master into abcc272 on jkeyes:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 16, 2017

Coverage Status

Coverage increased (+0.01%) to 95.842% when pulling fcdce48 on tanasegabriel:master into abcc272 on jkeyes:master.

@tanasegabriel tanasegabriel changed the title Extend error handling and added support for finding admin by ID Extended error handling and added support for finding admin by ID Oct 16, 2017
@jkeyes
Copy link
Contributor

jkeyes commented Oct 24, 2017

@tanasegabriel Can you revert your changes to travis.yml and to admin.py as I've merged those from other PRs. I'll then be able to merge the additions you've made to the error handling module.

This reverts commit fcdce48.

Reverting commit
@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage increased (+0.02%) to 95.854% when pulling 8151508 on tanasegabriel:master into abcc272 on jkeyes:master.

@tanasegabriel
Copy link
Contributor Author

@jkeyes Sure thing!

@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage increased (+0.02%) to 95.854% when pulling ec699cf on tanasegabriel:master into abcc272 on jkeyes:master.

@jkeyes jkeyes merged commit 60b1413 into intercom:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants