Bugfix: use apparent_encoding if encoding is set to None #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defeat value for encoding attribute in class
requests.Response
isNone
. If server doesn't set it to something useful (ie on 202 responses) it remainsNone
and gets passed todecode()
and thus fails. Classrequests. Response
has very nice fallback, apparent_encoding, that is provided by the chardet library and can come in handy here.