Merge pull request #92 from intergral/well_knowns

fix(service name): fix missing support for wellknown labels in tag va…
intergral · Mar 14, 2024 · ee8edac · ee8edac
2 parents 9c5f1e4 + 0b91bfc
commit ee8edac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 <!-- main START -->
 # main (unreleased)
 - **[BUGFIX]**: fix missing data in frame response [#89](https://github.com/intergral/deep/pull/89) [@Umaaz](https://github.com/Umaaz)
+- **[BUGFIX]**: fix missing support for well known labels [#92](https://github.com/intergral/deep/pull/92) [@Umaaz](https://github.com/Umaaz)
 <!-- main START -->
 
 <!-- main START -->

diff --git a/pkg/deepdb/encoding/vparquet/block_search_tags.go b/pkg/deepdb/encoding/vparquet/block_search_tags.go
@@ -214,6 +214,13 @@ func searchTagValues(ctx context.Context, tag deepql.Attribute, cb common.TagCal
 		return nil
 	}
 
+	if column, ok := wellKnownColumnLookups[tag.Name]; ok {
+		err := searchSpecialTagValues(ctx, column.columnPath, pf, cb)
+		if err != nil {
+			return fmt.Errorf("unexpected error searching special tags: %w", err)
+		}
+	}
+
 	// Finally also search generic key/values
 	err := searchStandardTagValues(ctx, tag, pf, cb)
 	if err != nil {