feat: load bitcoin network from rpc #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
feat/load-network
branch
from
cd75080
to
a4e5fca
Compare
sander2
reviewed
Feb 8, 2022
| } | ||
|
|
||
| /// Connect to a bitcoin-core full node or timeout. | ||
| async fn connect(rpc: &Client, connection_timeout: Duration) -> Result<Network, Error> { |
There was a problem hiding this comment.
Would it make sense to make this a private function in BitcoinCoreBuilder? Just to help with organization
There was a problem hiding this comment.
IMO no because it doesn't require any of the shared fields.
There was a problem hiding this comment.
It is possible to put functions in impls that do not take a self argument. But I don't feel super strongly enough about it, so approving..
There was a problem hiding this comment.
Yah but it's a private function anyway so I don't think it'll add much to the code organization.
sander2
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com
Adds a builder for the
BitcoinCorewrapper to optionally load the Bitcoin network from thegetblockchaininfoRPC.