refactor: update nomination spec with pre and post conditions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
sander2
previously requested changes
Jul 6, 2021
nud3l
reviewed
Jul 6, 2021
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/interlay/interbtc-spec/8o2rdbirUPeL8nzFgpefkencojpC |
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
|
I've specifically avoided mention of the Scalable Reward Distribution in this spec, it's still an open-point how to describe this. |
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
nud3l
reviewed
Jul 11, 2021
|
|
||
| * The BTC Parachain status in the :ref:`security` component must be set to ``RUNNING:0``. | ||
| * The Vault's collateral MUST increase by the amount nominated. | ||
| * The nominators balance MUST decrease by the amount nominated. |
There was a problem hiding this comment.
I guess also the nominator's staked amount or something must be increased?
There was a problem hiding this comment.
Yes, but I would reference this when we add the staking specification.
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com