refactor: remove AssetInfo, separate bootstrap account, cleanup errors #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
force-pushed
the
refactor/dex
branch
2 times, most recently
from
c5c1893
to
30b28c1
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
sander2
approved these changes
May 16, 2023
| /// only use two byte prefix to support 16 byte account id (used by test) | ||
| /// "modl" ++ "dex/stbl" is 12 bytes, and 4 bytes remaining for PoolId | ||
| pub fn pool_account_id(pool_id: &T::PoolId) -> T::AccountId { | ||
| T::PalletId::get().into_sub_account_truncating(pool_id) |
There was a problem hiding this comment.
A bit of a nit, and not really directly related to this pr, but if sizeof(poolId) > 4 or sizeof(PalletId) > 12) this doesn't really work I think (depending on endianness). But we're unlikely to change the runtime configuration so I guess it's fine..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanups I made while working on a separate issue