Worst case redeem benchmark #1056
Conversation
daniel-savu
force-pushed
the
dan/worst-case-bench-redeem
branch
from
c3ff058
to
81806e7
Compare
crates/redeem/src/benchmarking.rs
Outdated
| @@ -1,3 +1,5 @@ | |||
| #![cfg(feature = "runtime-benchmarks")] | |||
There was a problem hiding this comment.
Not required since it is already specified in lib.rs
| &loans::GenesisConfig { | ||
| max_exchange_rate: Rate::from_inner(DEFAULT_MAX_EXCHANGE_RATE), | ||
| min_exchange_rate: Rate::from_inner(DEFAULT_MIN_EXCHANGE_RATE), | ||
| }, |
There was a problem hiding this comment.
Wondering if we can implement Default for this at source to use some sensible values then we don't need to re-declare this everywhere
There was a problem hiding this comment.
Default is already implemented but with different values than the ones in the tests. Instead of the 0.02 initial (min) exchange rate, tests use 1 because they break otherwise (at least when multiple collateral currencies are being checked).
| @@ -174,6 +180,7 @@ pub mod benchmarks { | |||
| mint_wrapped::<T>(&caller, amount.into()); | |||
|
|
|||
| mint_collateral::<T>(&vault_id.account_id, 100_000u32.into()); | |||
| mint_vault_collateral::<T>(&vault_id); | |||
There was a problem hiding this comment.
Does this not replace the call in the preceding line?
| if vault_id.collateral_currency().is_lend_token() { | ||
| mint_lend_tokens::<T>(&vault_id.account_id, vault_id.collateral_currency()); | ||
| } else { | ||
| mint_collateral::<T>(&vault_id.account_id, 100_000u32.into()); |
There was a problem hiding this comment.
Actually, this is not required right?
There was a problem hiding this comment.
It's not required right now, I just wanted to make it easy to change the collateral used by the vault in the future
Uses lend tokens as collateral in the redeem benchmarks, and re-generates the weights. This PR depends on #1052.