feat: add pallet-identity #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
force-pushed
the
feat/pallet-identity
branch
from
e551aa3
to
c1e153c
Compare
|
LGTM, but should this be marked breaking? Tbh I am not sure. It would break clients for sure because of unrecognized events, but we need metadata update after spec-version change anyway.. Should we rethink what we mark as breaking? |
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
feat/pallet-identity
branch
from
c1e153c
to
bbb5fc1
Compare
|
Tbh I'm not sure, though I think we do that to adjust the numbering of pallets in our runtime so entries can be grouped more easily. See for example the Acala runtime where groups start at multiples of 10. |
|
I'd be happy to merge this pending the comments above - I guess the grouping should possibly happen in a different PR though? |
sander2
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com